Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] - Timezone and expression construction for snooze created via Slack #4500

Merged
merged 2 commits into from
Mar 12, 2024
Merged

[Bugfix] - Timezone and expression construction for snooze created via Slack #4500

merged 2 commits into from
Mar 12, 2024

Conversation

wssheldon
Copy link
Contributor

Snooze filters created via Slack did not correctly set timezone to UTC, so they were always in the past. Additionally, the expression that was constructed did not match the expected format:

[
	{
		"or": [
			{
				"model": "Entity",
				"field": "id",
				"op": "==",
				"value": 35
			}
		]
	}
]

We update how we build the filter we pass to create_filter_expression:

        if form_data.get(DefaultBlockIds.entity_select):
            entities = [
                {"id": int(entity.value)}
                for entity in form_data[DefaultBlockIds.entity_select]
            ]

Which results in the correct expression.

This was tested E2E locally, debug output:

FOUND f=<SignalFilter #42> on INSTANCE with f.mode='active' and f.action='snooze' and f.expiration=datetime.datetime(2024, 3, 12, 19, 30, 36, 895947)
mode f.mode='active' was active
mode f.mode='active' was snooze
expiration f.expiration=datetime.datetime(2024, 3, 12, 19, 30, 36, 895947) was not less than current time 2024-03-12 16:30:52.327661+00:00
running query
RUNNING QUERY query=<sqlalchemy.orm.query.Query object at 0x1341b6f10> SELECT signal_instance.id AS signal_instance_id, signal_instance.case_id AS signal_instance_case_id, signal_instance.engagement_thread_ts AS signal_instance_engagement_thread_ts, signal_instance.case_type_id AS signal_instance_case_type_id, signal_instance.case_priority_id AS signal_instance_case_priority_id, signal_instance.filter_action AS signal_instance_filter_action, signal_instance.canary AS signal_instance_canary, signal_instance.raw AS signal_instance_raw, signal_instance.signal_id AS signal_instance_signal_id, signal_instance.project_id AS signal_instance_project_id, signal_instance.created_at AS signal_instance_created_at, signal_instance.updated_at AS signal_instance_updated_at 
FROM signal_instance LEFT OUTER JOIN (assoc_signal_instance_entities AS assoc_signal_instance_entities_1 JOIN entity ON entity.id = assoc_signal_instance_entities_1.entity_id) ON signal_instance.id = assoc_signal_instance_entities_1.signal_instance_id 
WHERE signal_instance.signal_id = %(signal_id_1)s AND entity.id = %(id_1)s
RUNNING EXPRESSION f.expression=[{'or': [{'model': 'Entity', 'field': 'id', 'op': '==', 'value': 84}]}]
Expression found 1 instances
FILTER 1 signal_instance.filter_action=<SignalFilterAction.snooze: 'snooze'>
FILTER 2 signal_instance.filter_action=<SignalFilterAction.snooze: 'snooze'>
FILTER 3 signal_instance.filter_action=<SignalFilterAction.snooze: 'snooze'> && filtered=True

@wssheldon wssheldon added the bug Something isn't working label Mar 12, 2024
@wssheldon wssheldon merged commit 408c3fe into master Mar 12, 2024
8 checks passed
@wssheldon wssheldon deleted the bugfix/snooze-slack branch March 12, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wssheldon